Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Add script to update peerDependencies during bumpp #544

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lee00678
Copy link
Collaborator

@lee00678 lee00678 commented Mar 28, 2025

The peerDependencies don't get updated automatically after the bumpp integration.

This fix added a script to run as part of bumpp to fix the issue.

To test: run npm run version and see if all version fields are updated, including peerDependencies in all related package.json files.

Cc @50rayn @rokotyan

@50rayn
Copy link
Contributor

50rayn commented Mar 28, 2025

@lee00678 looks ok. Sincerely, I'm Not a fan of PERL, but it seems like it works well :D for us.
After PNPM workspace intergration, this script will be useless, since then we'll be able to specify in peerDependencies "@unovis/ts": "workspace:*", and before publish PNPM automatically resolves workspace:* before publishing and replaces with resolved version on publish (link).

@lee00678
Copy link
Collaborator Author

@lee00678 looks ok. Sincerely, I'm Not a fan of PERL, but it seems like it works well :D for us. After PNPM workspace intergration, this script will be useless, since then we'll be able to specify in peerDependencies "@unovis/ts": "workspace:*", and before publish PNPM automatically resolves workspace:* before publishing and replaces with resolved version on publish.

I think we definitely need to have the peerDependency issue automated in the meantime. Otherwise it's going to be really easy to miss when we publish a new version.

@50rayn
Copy link
Contributor

50rayn commented Mar 28, 2025

Agree. Currently, the peerDependency version can be updated only "manually". So, the current script is our fix.

@lee00678 lee00678 force-pushed the qian/bumpp-fix-peerDep branch from 25ad2ae to a2a8491 Compare April 5, 2025 00:08
@@ -0,0 +1,23 @@
#!/bin/bash

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update file name as update-peer-dependencies.sh

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with the script, I will need to take a further look on this. Mark as Draft for now.

@lee00678 lee00678 marked this pull request as draft April 8, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants