-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc: Add script to update peerDependencies during bumpp #544
base: main
Are you sure you want to change the base?
Conversation
@lee00678 looks ok. Sincerely, I'm Not a fan of PERL, but it seems like it works well :D for us. |
I think we definitely need to have the peerDependency issue automated in the meantime. Otherwise it's going to be really easy to miss when we publish a new version. |
Agree. Currently, the peerDependency version can be updated only "manually". So, the current script is our fix. |
25ad2ae
to
a2a8491
Compare
@@ -0,0 +1,23 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update file name as update-peer-dependencies.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some issues with the script, I will need to take a further look on this. Mark as Draft for now.
The peerDependencies don't get updated automatically after the bumpp integration.
This fix added a script to run as part of bumpp to fix the issue.
To test: run
npm run version
and see if all version fields are updated, including peerDependencies in all related package.json files.Cc @50rayn @rokotyan