-
-
Notifications
You must be signed in to change notification settings - Fork 322
Addition of --axesGrid option #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You are modifying libf3d public API! |
Looks like your rebase/merge with master did not work as you expected, let me know if you need help with that :) |
Hey @ArchiePayne Do you need help moving forward ? |
As discussed on discord, we should hold this feature until the more advanced version from ParaView is being integrated to VTK. Please notify this thread when this happens and we can move forward :) |
|
Hi @ArchiePayne Need any help moving forward ? |
Apologies I've only seen this @mwestphal, I will be looking into this again! |
@ArchiePayne I'm not sure what you did but the commit list/change list looks wrong. Please rebase on the latest master and keep only your own commits. |
@mwestphal Apologies, unsure what I did but think I've fixed it now. |
Do you need help @ArchiePayne ? :) |
Yes please! :) |
If you read the CI results, I think it become quite clear :)
Which is expected because this BTW you can enable |
This reverts commit 9ee8243.
…'t fail cmake commands.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
To be complete this misses update to the doc in doc/user/OPTIONS.md
I have updated the documentation. Please let me know if the wording is okay |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Added command line argument --axesGrid which maps to render.cubeAxis.enable.
Support showing the vtkCubeAxesActor within the viewport, matching to bounding box of the model.
Added application layer test for this option.
Fix #7