Skip to content

Addition of --axesGrid option #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jul 13, 2025
Merged

Addition of --axesGrid option #2100

merged 28 commits into from
Jul 13, 2025

Conversation

ArchiePayne
Copy link
Contributor

@ArchiePayne ArchiePayne commented Mar 28, 2025

Added command line argument --axesGrid which maps to render.cubeAxis.enable.

Support showing the vtkCubeAxesActor within the viewport, matching to bounding box of the model.

Added application layer test for this option.

Fix #7

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

Copy link

github-actions bot commented Mar 28, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal
Copy link
Member

Looks like your rebase/merge with master did not work as you expected, let me know if you need help with that :)

@mwestphal
Copy link
Member

Hey @ArchiePayne

Do you need help moving forward ?

@ArchiePayne
Copy link
Contributor Author

@mwestphal

As discussed on discord, we should hold this feature until the more advanced version from ParaView is being integrated to VTK. Please notify this thread when this happens and we can move forward :)

@mwestphal
Copy link
Member

vtkGridAxesActor3D has been added in VTK master

@mwestphal
Copy link
Member

@ArchiePayne

@mwestphal
Copy link
Member

Hi @ArchiePayne

Need any help moving forward ?

@ArchiePayne
Copy link
Contributor Author

Apologies I've only seen this @mwestphal, I will be looking into this again!

@mwestphal
Copy link
Member

@ArchiePayne I'm not sure what you did but the commit list/change list looks wrong.

Please rebase on the latest master and keep only your own commits.

@ArchiePayne
Copy link
Contributor Author

@ArchiePayne I'm not sure what you did but the commit list/change list looks wrong.

Please rebase on the latest master and keep only your own commits.

@mwestphal Apologies, unsure what I did but think I've fixed it now.

@mwestphal
Copy link
Member

Do you need help @ArchiePayne ? :)

@ArchiePayne
Copy link
Contributor Author

Do you need help @ArchiePayne ? :)

Yes please! :)

@mwestphal
Copy link
Member

mwestphal commented Jul 5, 2025

If you read the CI results, I think it become quite clear :)

[ 36%] Building CXX object vtkext/private/module/CMakeFiles/vtkextPrivate.dir/vtkF3DSolidBackgroundPass.cxx.o
/__w/f3d/f3d/source/vtkext/private/module/vtkF3DRenderer.cxx: In member function 'void vtkF3DRenderer::ConfigureGridAxesUsingCurrentActors()':
/__w/f3d/f3d/source/vtkext/private/module/vtkF3DRenderer.cxx:778:14: error: unused variable 'bounds' [-Werror=unused-variable]
  778 |       double bounds[6] = { a, b, c, x, y, z };
      |              ^~~~~~
[ 37%] Building CXX object vtkext/private/module/CMakeFiles/vtkextPrivate.dir/vtkF3DUIObserver.cxx.o

Which is expected because this bounds var doesnt seems to be used. You can just remove it.

BTW you can enable F3D_STRICT_BUILD to trigger this locally I believe.

ArchiePayne and others added 2 commits July 13, 2025 11:45
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ArchiePayne ArchiePayne reopened this Jul 13, 2025
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

To be complete this misses update to the doc in doc/user/OPTIONS.md

@ArchiePayne
Copy link
Contributor Author

Nice!

To be complete this misses update to the doc in doc/user/OPTIONS.md

I have updated the documentation. Please let me know if the wording is okay

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mwestphal mwestphal merged commit d1d3319 into f3d-app:master Jul 13, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to draw axes actor
2 participants