Skip to content

Add ImGui Minimal Console Feature #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Apr 24, 2025
Merged

Conversation

dh-you
Copy link
Contributor

@dh-you dh-you commented Mar 28, 2025

Addresses #1817

  • new option ui.minimal_console
  • minimal console feature added to vtkext/private/module/vtkF3DImguiConsole.cxx

dh-you and others added 3 commits March 28, 2025 06:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dh-you added 2 commits March 28, 2025 17:25
- added HideMinimalConsoleEvent
- changed OPTIONS.md description for minimal_console
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dh-you and others added 2 commits March 28, 2025 17:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.h
    • lines 50-50

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dh-you dh-you requested a review from mwestphal April 16, 2025 21:39
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes and questions

@mwestphal
Copy link
Member

So after discussion, lets move the minimal console up, aligned with console badge

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few last nitpicks :)

added end of line to minimal console tests
@dh-you dh-you requested a review from mwestphal April 23, 2025 19:54
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A baseline to update

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.87%. Comparing base (acc053c) to head (3b126e9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vtkext/private/module/vtkF3DUIActor.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2099      +/-   ##
==========================================
+ Coverage   95.86%   95.87%   +0.01%     
==========================================
  Files         127      127              
  Lines       11060    11090      +30     
==========================================
+ Hits        10603    10633      +30     
  Misses        457      457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@mwestphal mwestphal merged commit 5da3b8f into f3d-app:master Apr 24, 2025
53 checks passed
@mwestphal
Copy link
Member

Thanks for the contribution @wizzebit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants