Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for KFAC-expand and KFAC-reduce for Linear modules #63

Merged
merged 17 commits into from
Jan 12, 2024
Merged

Add support for KFAC-expand and KFAC-reduce for Linear modules #63

merged 17 commits into from
Jan 12, 2024

Conversation

runame
Copy link
Collaborator

@runame runame commented Jan 9, 2024

Resolves #50.

This PR is based on #62 which should be reviewed first. I will tackle #45 next and directly implement expand and reduce (will reuse most of the code for linear modules since it is almost identical).

@runame runame added the enhancement New feature or request label Jan 9, 2024
@runame runame requested a review from f-dangel January 9, 2024 21:48
@runame runame linked an issue Jan 9, 2024 that may be closed by this pull request
Support KFAC-expand and KFAC-reduce for linear weight-sharing layers. #50
Closed
@coveralls
Copy link

coveralls commented Jan 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7504675036

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.6%) to 88.087%
Totals Coverage Status
Change from base Build 7488515245: -4.6%
Covered Lines: 769
Relevant Lines: 873
💛 - Coveralls

This was referenced Jan 10, 2024
Merged
Merged
@f-dangel
Copy link
Owner

Ping me after #62 is merged (I believe yo also need to set the target branch of this PR to main).

Base automatically changed from high-dim-outputs to development January 11, 2024 12:08
runame added 2 commits January 11, 2024 15:06
@runame
Merge branch 'development' into expand-reduce
fb405a8 
Conflicts:
	curvlinops/kfac.py
	test/test_kfac.py
	test/utils.py
@runame
Remove unused line
5ce3579
@runame
Copy link
Collaborator Author

runame commented Jan 11, 2024

@f-dangel I merged #62 and resolved merge conflicts with this branch. (I previously set the base branch to the branch from #62 so the diffs are better visible, it got automatically changed to development after merging #62.)

f-dangel
f-dangel approved these changes Jan 11, 2024
View reviewed changes
Copy link
Owner

@f-dangel f-dangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great up to minor stuff, please feel free to merge after addressing.

curvlinops/kfac.py Outdated Show resolved Hide resolved
curvlinops/kfac.py Outdated Show resolved Hide resolved
curvlinops/kfac.py Outdated Show resolved Hide resolved
curvlinops/kfac.py Outdated Show resolved Hide resolved
test/kfac_cases.py Outdated Show resolved Hide resolved
test/utils.py Outdated Show resolved Hide resolved
test/utils.py Outdated Show resolved Hide resolved
@runame runame changed the title Add support for KFAC-expand and KFAC-reduce for linear modules Add support for KFAC-expand and KFAC-reduce for Linear modules Jan 12, 2024
@runame runame merged commit 5f60692 into development Jan 12, 2024
13 checks passed
@runame runame deleted the expand-reduce branch January 12, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-dangel f-dangel f-dangel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support KFAC-expand and KFAC-reduce for linear weight-sharing layers.
3 participants
@runame @coveralls @f-dangel