Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Make trace/diagonal estimators functional #168

Merged
merged 17 commits into from
Jan 16, 2025
Merged

[REF] Make trace/diagonal estimators functional #168

merged 17 commits into from
Jan 16, 2025

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Jan 7, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12656167608

Details

  • 23 of 27 (85.19%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.169%
Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/trace/hutchinson.py 7 9 77.78%
curvlinops/trace/meyer2020hutch.py 14 16 87.5%
Totals Coverage Status
Change from base Build 12573122785: -0.2%
Covered Lines: 1364
Relevant Lines: 1464
💛 - Coveralls

@f-dangel f-dangel changed the title [REF] Make trace estimators functional [REF] Make trace/diagonal estimators functional Jan 7, 2025
@f-dangel f-dangel requested a review from runame January 8, 2025 15:49
@f-dangel f-dangel mentioned this pull request Jan 9, 2025
Open
runame
runame approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

curvlinops/diagonal/hutchinson.py Show resolved Hide resolved
curvlinops/diagonal/hutchinson.py Outdated Show resolved Hide resolved
curvlinops/trace/hutchinson.py Show resolved Hide resolved
curvlinops/diagonal/hutchinson.py Outdated Show resolved Hide resolved
curvlinops/trace/meyer2020hutch.py Show resolved Hide resolved
@f-dangel f-dangel requested a review from runame January 15, 2025 16:06
runame
runame reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@f-dangel f-dangel merged commit 53267c5 into main Jan 16, 2025
11 checks passed
@f-dangel f-dangel deleted the functional-estimators branch January 16, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-dangel @runame