Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Implement XTrace trace estimator #166

Merged
merged 8 commits into from
Jan 8, 2025
Merged

[ADD] Implement XTrace trace estimator #166

merged 8 commits into from
Jan 8, 2025

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Jan 6, 2025

No description provided.

@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12672382119

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 31 of 33 (93.94%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.338%

Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/trace/epperly2024xtrace.py 30 32 93.75%
Totals Coverage Status
Change from base Build 12573122785: 0.01%
Covered Lines: 1415
Relevant Lines: 1516

💛 - Coveralls

@f-dangel f-dangel requested a review from runame January 7, 2025 16:01
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the algorithm (would have to look at the paper for that), but the implementation LGTM.

curvlinops/trace/epperly2024xtrace.py Outdated Show resolved Hide resolved
curvlinops/trace/epperly2024xtrace.py Outdated Show resolved Hide resolved
@f-dangel f-dangel merged commit ea7238c into main Jan 8, 2025
12 of 13 checks passed
@f-dangel f-dangel deleted the xtrace branch January 8, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants