fix: Checking for file existence before deleting in Serializer.php #443
Merged
ezyang merged 1 commit intoezyang:masterfrom Jun 6, 2025
Merged
fix: Checking for file existence before deleting in Serializer.php #443ezyang merged 1 commit intoezyang:masterfrom
ezyang merged 1 commit intoezyang:masterfrom
Conversation
fix : prevent deleting a file that does not exist ezyang#442
dadkhah-dev
changed the title
ezyang
approved these changes
Jun 6, 2025
Owner
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
There's still a potential race condition here, so it would be better to unconditionally unlink and suppress file not found error if it occurs. But this is fine.
|
🎉 This PR is included in version 4.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix : prevent deleting a file that does not exist #442