Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-26835 : Script to extract translations #1883

Merged
merged 2 commits into from
Jan 18, 2017

Conversation

nicolas-bastien
Copy link
Contributor

@nicolas-bastien nicolas-bastien commented Jan 17, 2017

Jira : https://jira.ez.no/browse/EZP-26835

Description

Add a script to extract translations from sources.

This script is present in the bundle, next step will be to execute this during CI to validate that each PR contains every translation needed.

To extract repositoy_exception correctly I had to do this PR on JMS translation bundle : schmittjoh/JMSTranslationBundle#427

So as this PR is merged, extract is working if jms is plugged on my branch.

./app/console translation:extract en -v \
--dir=./vendor/ezsystems/ezpublish-kernel/eZ \
--exclude-dir=Bundle/PlatformBehatBundle \
--exclude-dir=Bundle/EzPublishCoreBundle/Tests \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try --exclude-dir=Tests. If I remember correctly, it will work.

@@ -1,113 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the exceptions were moved to messages. It shouldn't have happened.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is .pt.xlf so I removed it manually

For the strings added to messages it's due to this : schmittjoh/JMSTranslationBundle#427

@nicolas-bastien nicolas-bastien merged commit 0a2dc57 into master Jan 18, 2017
@nicolas-bastien nicolas-bastien deleted the EZP-26835-translation-extraction branch January 18, 2017 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants