Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add non-nix pre-commit rustfmt and clippy hooks #986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add non-nix pre-commit rustfmt and clippy hooks #986

wants to merge 1 commit into from

Conversation

PThorpe92
Copy link
Member

For those of us who don't use nix on a daily basis, it's nice to have the option of getting rustfmt + clippy running before we commit.

@PThorpe92 PThorpe92 requested a review from cafkafk as a code owner May 12, 2024 16:54
gierens
gierens previously approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my boring Arch (btw) 🚀

cafkafk
cafkafk requested changes May 13, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
gierens
gierens requested changes May 13, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@PThorpe92 PThorpe92 enabled auto-merge (rebase) June 7, 2024 11:15
@PThorpe92
Copy link
Member Author

@cafkafk this is ready 👍

cafkafk
cafkafk requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the merge update and instead use a rebase to get the branch up to date with main? Using merge clutters the commit log unnecessarily. Else looks good 👍

@cafkafk cafkafk disabled auto-merge June 24, 2024 04:38
@PThorpe92
Copy link
Member Author

PThorpe92 commented Jun 25, 2024 •
edited
Loading

wait... don't those merge commits get squashed?

EDIT: just looked through git history... wow wtf how does github not merge --squash when repos have rebase only enabled? I had no idea those commits were staying here the whole time

@PThorpe92
feat: add non-nix pre-commit rustfmt and clippy hooks
e3eeb2c 
fix: correct nix pre-commit, update instructions

chore: rename non-nix pre commit cfg and update docs to reflect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafkafk cafkafk cafkafk requested changes

@gierens gierens gierens approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PThorpe92 @gierens @cafkafk