Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add templ icon #977

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add templ icon #977

wants to merge 2 commits into from

Conversation

sachinsenal0x64
Copy link

@sachinsenal0x64 sachinsenal0x64 commented May 9, 2024 •
edited
Loading

Add an icon for files associated with Templ templating language:

  • *.templ

PThorpe92
PThorpe92 approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sachinsenal0x64 @MartinFillon
feat: add templ icon
05565fe 
Signed-off-by: sachin senal <[email protected]>
cafkafk
cafkafk requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to fail here, also the merge commit is unnescessary, it would be preferred if this was rebased on main instead of merging. LMK if you need any help :)

@sachinsenal0x64
Copy link
Author

sachinsenal0x64 commented Jun 17, 2024 •
edited
Loading

CI seems to fail here, also the merge commit is unnescessary, it would be preferred if this was rebased on main instead of merging. LMK if you need any help :)

Yeah, sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafkafk cafkafk cafkafk requested changes

@PThorpe92 PThorpe92 PThorpe92 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sachinsenal0x64 @cafkafk @PThorpe92