Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cargo clippy warning and error #936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtczza
Copy link

@rtczza rtczza commented Apr 18, 2024

fix cargo clippy warning and error

@MartinFillon
Copy link
Contributor

Hey could you explain to me on which os you got those errors ?

@rtczza
Copy link
Author

rtczza commented Apr 22, 2024

I understand that it has less to do with the OS and more to do with the rust version.

The OS version is: Deepin 20.9

The rust version is: 1.75-x86_64-unknown-linux-gnu

The test command is: cargo clippy --locked --all-targets --all-features

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution. I can reproduce the issue when running cargo clippy --locked --all-targets --all-features.

Three are some issues that need to be resolved.


Firstly the commits should follow conventional commits, you can read more about this is our CONTRIBUTING.md file.

Secondly, this does seem to break CI, specifically for one of of the BSD targets. I've rebased the PR onto the latest main branch, if that doesn't fix it, we should try to see if we can find someone knowledgeable about BSD to fix it (unless you know how to do that).

@rtczza
Copy link
Author

rtczza commented May 10, 2024

Sorry, I don't know what changes should be made to repair CI, can you help me to modify it? Or tell me exactly what to do?

@cafkafk
Copy link
Member

cafkafk commented May 10, 2024

Sorry, I don't know what changes should be made to repair CI, can you help me to modify it? Or tell me exactly what to do?

You should run "git commit --amendand change the commit summary to something likefix(cargo): clippy warning and error` which conforms to the conventional commit standard. After that, you should push your changes. You might need to force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants