fix: removes trailing /*
from --ignore-glob
#879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes trailing
/
or/*
and should fix #865.Where globs ending with those patterns would not match any directory, as the default listing doesn't include an ending
/
.As mentioned here, the pattern generated by a glob that ends either in
/
or/*
, such asnode_modules/*
ornode_modules/*
would not match as the default listing of directories don't include those characters.Description
I added a line at that goes as follows:
Removing both patterns when they exists at the end of the glob. Here is a screenshot of it working:
How Has This Been Tested?
Should I write new unit tests for this specific case?