Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing line breaks in zsh completions #1037

Merged

Conversation

matyama
Copy link
Contributor

@matyama matyama commented Jun 27, 2024

Before this change the shell would report a parsing error, which was due to missing line breaks after the newly introduced symlinks flags. This commit fixes that issue.

Closes #1038

Before this change the shell would report a parsing error, which was due
to missing line breaks after the newly introduced symlinks flags. This
commit fixes that issue.
@aryklein
Copy link

Please merge this PR to fix the issue #1038
Thanks

@alerque
Copy link

alerque commented Jun 29, 2024

Is there a chance this can get fast tracked into a release or should I look into backporting the patch to the Arch Linux release? It's a pretty obnoxious bug.

@MrAureliusR
Copy link

This really does need to be merged or backported -- there are a lot of Arch users having this issue, including me. It's a simple typo in a config file, I don't think it needs a huge amount of review.

@alerque
Copy link

alerque commented Jun 29, 2024

I just backported this to the Arch package because it was too disruptive to my own daily work not to be able to tab complete my ls!

Copy link

@trinitronx trinitronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1, looks good to me 😁

@sweetbbak
Copy link
Contributor

for anyone who wants a quick and dirty fix you can run compdef -d eza on shell init until this is fixed

@PThorpe92 PThorpe92 enabled auto-merge (rebase) June 30, 2024 21:13
@PThorpe92
Copy link
Member

🙏 Sorry everyone, I see that was my mistake -_-

Will get this out asap! Thanks for the fix ❤️

@cafkafk
Copy link
Member

cafkafk commented Jul 1, 2024

Is there a chance this can get fast tracked into a release or should I look into backporting the patch to the Arch Linux release? It's a pretty obnoxious bug.

Currently on fast track, think I'll cut a release today with this :)

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, LGTM 👍

@cafkafk cafkafk disabled auto-merge July 1, 2024 04:44
@cafkafk cafkafk merged commit cdeae92 into eza-community:main Jul 1, 2024
1 check passed
@matyama matyama deleted the fix-zsh-completions-symlinks-flags branch July 1, 2024 05:01
@cafkafk
Copy link
Member

cafkafk commented Jul 1, 2024

This was just released https://github.com/eza-community/eza/releases/tag/v0.18.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

bug: Autocompletion Crash on eza v0.18.20 with Zsh
8 participants