-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing line breaks in zsh completions #1037
Fix missing line breaks in zsh completions #1037
Conversation
Before this change the shell would report a parsing error, which was due to missing line breaks after the newly introduced symlinks flags. This commit fixes that issue.
Please merge this PR to fix the issue #1038 |
Is there a chance this can get fast tracked into a release or should I look into backporting the patch to the Arch Linux release? It's a pretty obnoxious bug. |
This really does need to be merged or backported -- there are a lot of Arch users having this issue, including me. It's a simple typo in a config file, I don't think it needs a huge amount of review. |
I just backported this to the Arch package because it was too disruptive to my own daily work not to be able to tab complete my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 +1, looks good to me 😁
for anyone who wants a quick and dirty fix you can run |
🙏 Sorry everyone, I see that was my mistake -_- Will get this out asap! Thanks for the fix ❤️ |
Currently on fast track, think I'll cut a release today with this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix, LGTM 👍
This was just released https://github.com/eza-community/eza/releases/tag/v0.18.21 |
Before this change the shell would report a parsing error, which was due to missing line breaks after the newly introduced symlinks flags. This commit fixes that issue.
Closes #1038