Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ln=target in LS Colors (exa PR 960) #1018

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbrubake
Copy link

@jbrubake jbrubake commented Jun 6, 2024

Setting "ln=target" highlights a link in the same color as the referred file instead of having a specific symlink color. Dangling/orphaned links are always colored using the specified "or=" color.

(Credit to @LarsHaalck who wrote the original ogham/exa#960)

@jbrubake jbrubake requested a review from PThorpe92 as a code owner June 6, 2024 21:24
@MartinFillon
Copy link
Contributor

Hey, thanks for updating the pr, I will let you fix clippy lints error and check for format error in your code, they are mentionned in the checks not passing

Copy link
Contributor

@MartinFillon MartinFillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your patience and for fixing everything.

Copy link
Member

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Target,
}

impl Default for LinkStyle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can this be derived?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I don't know what that means. I don't actually know Rust. I just took the original patch and tweaked it to work with the current code

If you can point me in the right direction though, I'm happy to take a look

Setting "ln=target" highlights a link in the same color as the
referred file. Dangling/orphaned links are always colored using the
specified "or=" color.

(Credit to @LarsHaalck who wrote the original ogham/exa#960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants