Skip to content

Commit

Permalink
fix: build aarch64, arm without libgit2
Browse files Browse the repository at this point in the history 
Signed-off-by: Christina Sørensen <[email protected]>
  • Loading branch information
@cafkafk
cafkafk committed Apr 13, 2024
1 parent 17733e9 commit 07f6770
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions Justfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,18 @@ binary_static BINARY TARGET:
just tar_static {{BINARY}} {{TARGET}}
just zip_static {{BINARY}} {{TARGET}}

binary_no_libgit BINARY TARGET:

This comment has been minimized.

Sign in to view

Copy link
@evrial

evrial May 11, 2024

Cool fix.

eza --git
eza: Options --git and --git-ignore can't be used because `git` feature was disabled in this build of exa

This comment has been minimized.

Sign in to view

Copy link
@evrial

evrial May 11, 2024

@gierens can you please undo the damage done here?

This comment has been minimized.

Sign in to view

Copy link
@gierens

gierens May 12, 2024

Member

@evrial Thanks for the feedback. Could you please open an issue with the proper context, on what system does this happen and why would this line be the cause of it. Then we can discuss it there and we don't have to guess.

This comment has been minimized.

Sign in to view

Copy link
@cafkafk

cafkafk May 12, 2024

Author Member

This is currently disabled due to libgit2 containing a potential vulnerability on aarch64, you can compile it yourself if you are willing to take that risk, but we do not wish to distribute insecure software. Rest assured we will resume distributing this when upstream fixes this.

Please consider being more polite in the future if you wish to continue participating in eza.

This comment has been minimized.

Sign in to view

Copy link
@evrial

evrial May 12, 2024

From my perspective making implicit breaking changes also unpolite and unethical.

This comment has been minimized.

Sign in to view

Copy link
@cafkafk

cafkafk May 12, 2024

Author Member

We'll make sure to label it breaking next time (we did put it in the release notes), but no, this is not unethical :)

This comment has been minimized.

Sign in to view

Copy link
@evrial

evrial May 12, 2024

Great, THANKS
rustup target add {{TARGET}}
cross build --no-default-features --release --target {{TARGET}}
just tar {{BINARY}} {{TARGET}}
just zip {{BINARY}} {{TARGET}}

binary_static_no_libgit BINARY TARGET:
rustup target add {{TARGET}}
RUSTFLAGS='-C target-feature=+crt-static' cross build --no-default-features --release --target {{TARGET}}
just tar_static {{BINARY}} {{TARGET}}
just zip_static {{BINARY}} {{TARGET}}

checksum:
@echo "# Checksums"
@echo "## sha256sum"
Expand Down Expand Up @@ -190,11 +202,11 @@ alias c := cross
# just binary_static eza x86_64-unknown-linux-musl

### aarch
just binary eza aarch64-unknown-linux-gnu
just binary_no_libgit eza aarch64-unknown-linux-gnu
# BUG: just binary_static eza aarch64-unknown-linux-gnu

### arm
just binary eza arm-unknown-linux-gnueabihf
just binary_no_libgit eza arm-unknown-linux-gnueabihf
# just binary_static eza arm-unknown-linux-gnueabihf

## MacOS
Expand Down

0 comments on commit 07f6770

Please sign in to comment.