Update Constants.php

[dpDesignz]

Update _isNULL and _notNULL constants to allow checks to run correctly.

Discovered that the isNull and isNotNull where conditions were not firing correctly due to incorrectly declared constants.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (4bc6a25) to head (e690998).
Report is 4 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage     90.30%   90.76%   +0.46%     
  Complexity      838      838              
============================================
  Files            14       14              
  Lines          2083     2058      -25     
============================================
- Hits           1881     1868      -13     
+ Misses          202      190      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheTechsTech]

Update _isNULL and _notNULL constants to allow checks to run correctly.

Discovered that the isNull and isNotNull where conditions were not firing correctly due to incorrectly declared constants.

Those constants also suppose to build create the actual SQL query string format. There might not be enough or no tests covering them. The ezFunctionsTest.php does not actually touch any database.

Seems the Windows Github Actions Ci needs fixing now.

[dpDesignz]

Update _isNULL and _notNULL constants to allow checks to run correctly.
Discovered that the isNull and isNotNull where conditions were not firing correctly due to incorrectly declared constants.

Those constants also suppose to build create the actual SQL query string format. There might not be enough or no tests covering them. The ezFunctionsTest.php does not actually touch any database.

Seems the Windows Github Actions Ci needs fixing now.

It failed the test when I left the $y value lowercase because it was doing an assertive array check in the test files, so I made them uppercase to match the values defined in the constants. I've been trying to work out for weeks why the NULL conditions weren't working but I only actually looked into it last night because I needed it for a query to run properly.

[TheTechsTech]

The naming of the constants and meaning actually represent contents without spacing.

Seems there might be some logic bugs elsewhere that should be looked at too. see

ezsql/lib/ezQuery.php

Line 334 in 4bc6a25

private function conditionIs($key, $condition, $combine)

and

ezsql/lib/ezQuery.php

Line 386 in 4bc6a25

private function processConditions($column, $condition, $value, $valueOrCombine, $extraCombine)

This construction will actually produced IS NOT NULL null the $y = 'null' not really needed.

[TheTechsTech]

It failed the test when I left the $y value lowercase because it was doing an assertive array check in the test files, so I made them uppercase to match the values defined in the constants. I've been trying to work out for weeks why the NULL conditions weren't working but I only actually looked into it last night because I needed it for a query to run properly.

After looking a little further, there are other issues as mentioned, seems the need for more coverage tests should be done too.

Plus test under PHP 8.1 for compatibility, this part I been wanting to do for over 2 months now. Just not in the right mind to address issues, got many other things I'm working on.

[dpDesignz]

The naming of the constants and meaning actually represent contents without spacing.

Seems there might be some logic bugs elsewhere that should be looked at too. see

ezsql/lib/ezQuery.php

Line 334 in 4bc6a25

private function conditionIs($key, $condition, $combine)

and

ezsql/lib/ezQuery.php

Line 386 in 4bc6a25

private function processConditions($column, $condition, $value, $valueOrCombine, $extraCombine)

This construction will actually produced IS NOT NULL null the $y = 'null' not really needed.

Yea I had originally tried removing this as well but it wouldn't parse without those values so that's why I used the solution that I have as that does parse with no issues.

Unfortunately, I'm in the same space as you otherwise I would have sorted this earlier myself.