Fix #766 SVGParser will parse the class attribute as Node Tag.#787
Open
ty0x2333 wants to merge 1 commit intoexyte:masterfrom
Open
Fix #766 SVGParser will parse the class attribute as Node Tag.#787ty0x2333 wants to merge 1 commit intoexyte:masterfrom
class attribute as Node Tag.#787ty0x2333 wants to merge 1 commit intoexyte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Macaw for SVG rendering.
I have the same problem as #766
I need to dynamically modify the style by
class. But there is no way to get nodes byclass.SVGParser currently only parses
idas a Node Tag. This Pull Request parsesclassas a Node Tag as well.This way, the node of the specified class can be found by the
node.nodesBy(tag:)method without breaking the original design.