Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use token to install libextism #25

Merged
merged 2 commits into from
Aug 23, 2024
Merged

ci: use token to install libextism #25

merged 2 commits into from
Aug 23, 2024

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Aug 23, 2024 •
edited
Loading

This method is superior to the other methods of passing the token to the workflow as it doesn't require explicitly passing the token.

https://szabo.jp/2023/06/18/accessing-the-github-token-from-an-action/

@G4Vi G4Vi changed the title ci: test invalid token ci: use token to install libextism Aug 23, 2024
@G4Vi G4Vi requested a review from zshipko August 23, 2024 17:01
@G4Vi G4Vi marked this pull request as ready for review August 23, 2024 17:02
zshipko
zshipko approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I will fix the macOS/hlint failure in another PR

@G4Vi G4Vi merged commit 08b68cb into main Aug 23, 2024
1 of 2 checks passed
@G4Vi G4Vi deleted the ci-install-libextism-token branch August 23, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G4Vi @zshipko