-
Notifications
You must be signed in to change notification settings - Fork 29
feat: add use_extendr_badge() #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JosiahParry
wants to merge
5
commits into
main
Choose a base branch
from
badge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
646270c
add use_extendr_badge()
JosiahParry 2cdae4e
update NEWS.md and add to NAMESPACE and pkgdown
JosiahParry acb6da2
remove extendr badge from readme
JosiahParry a0c3d1e
Merge branch 'main' into badge
JosiahParry 9bd0985
Merge branch 'main' into badge
JosiahParry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#' extendr README badge | ||
#' | ||
#' Add the version of extendr being used by an R package to its README. | ||
#' | ||
#' Requires `usethis` to be available. | ||
#' | ||
#' @examples | ||
#' \dontrun{ | ||
#' use_extendr_badge() | ||
#' } | ||
#' | ||
#' @inheritParams use_extendr | ||
#' @export | ||
use_extendr_badge <- function(path = ".") { | ||
rlang::check_installed("usethis") | ||
meta <- read_cargo_metadata(path) | ||
deps <- meta[[c("packages", "dependencies")]][[1]] | ||
|
||
if (rlang::is_null(deps)) { | ||
cli::cli_abort("Unable to determine version of `extendr-api`") | ||
} | ||
|
||
is_extendr <- which(deps$name == "extendr-api") | ||
if (!rlang::is_bare_numeric(is_extendr, 1)) { | ||
cli::cli_abort("Unable to determine version of `extendr-api`") | ||
} | ||
|
||
extendr_version <- deps$req[is_extendr] | ||
|
||
usethis::use_badge( | ||
"extendr", | ||
"https://extendr.github.io/extendr/extendr_api/", | ||
sprintf("https://img.shields.io/badge/extendr-%s-276DC2", extendr_version) | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,3 +32,4 @@ reference: | |
- make_module_macro | ||
- rust_sitrep | ||
- read_cargo_metadata | ||
- use_extendr_badge |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use it by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, as a point of encouragement. It does quite literally nothing other than print a message to the console. The hope is that users can add it to their package for a bit of flair and provide and indication that they're R package is rust powered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like it defeats the purpose, a user still have to run
use_extendr()
once. What's the point of a separate function? Perhaps it is better to show here an invite to runrextendr::use_extendr_badge()
?