Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace jest with vitest in the dependencies section #27

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

Amorim33
Copy link
Contributor

@Amorim33 Amorim33 commented Sep 15, 2023

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

PR Type

What kind of change does this PR introduce?

  • Documentation fix
  • Documentation update
  • New Feature
  • Translation:: New language
  • Bugfix
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.
Pull Request Number: expressots/expressots#88

-> Response:
Jest is listed in the core dependencies doc.

What is the new behavior?

Describe the new behavior or link to a relevant issue.

-> Response:
Jest is replaced by Vitest in the core dependencies doc.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

-> Response:

Other information

Any other information that is important to this PR.

  • N/A

-> Response:

@ghost
Copy link

ghost commented Sep 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Amorim33 Amorim33 force-pushed the chore/replace-jest-with-vitest branch from 5c63991 to 064c9eb Compare September 15, 2023 22:38
@rsaz rsaz merged commit 5a6bdd2 into main Sep 16, 2023
1 check passed
@rsaz rsaz deleted the chore/replace-jest-with-vitest branch September 16, 2023 05:56
@rsaz rsaz assigned rsaz and Amorim33 and unassigned rsaz Sep 16, 2023
@rsaz rsaz self-requested a review September 16, 2023 05:57
@rsaz rsaz added the doc fix Fix of documentation label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc fix Fix of documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants