Skip to content

chore(deps): update devDependencies #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented Apr 28, 2025

This PR contains 3 commits:

  • a726d38 unpinning all remaining pinned devDepenencies
  • 838011d updating the test dependencies
  • 4c0c27b removing --bail from the test script

Copy link

socket-security bot commented Apr 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedeslint-plugin-import@​2.25.4 ⏵ 2.31.09810010082100
Updatedsupertest@​6.3.4 ⏵ 7.1.099100100 +186100
Updatedmocha@​10.8.2 ⏵ 11.2.297 +110094 +194100

View full report

@Phillip9587
Copy link
Contributor Author

Phillip9587 commented Apr 28, 2025

That's interesting - it looks like all tests related to "traversing past root" are failing after the test dependency update. I'll investigate whether this is connected to the supertest update.

@Phillip9587
Copy link
Contributor Author

I confirmed that this appears to be a bug with supertest. The tests also fail in send when updating to supertest v7, and even the Fastify fork’s tests fail when updated (see fastify/send#110).

@UlisesGascon How would you like to proceed? Should I update the tests to use the native fetch API with a real HTTP server instead of supertest, or should we consider using something like node-mocks-http to mock requests and responses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant