feat: add deprecation notice for header overwriting in redirects #199
Conversation
| @@ -2,6 +2,7 @@ | |||
| =================== | |||
|
|
|||
| * Changes from 1.16.0 | |||
| * In the next major version, headers will no longer be overwritten when redirecting a directory. | |||
There was a problem hiding this comment.
v2.1.0 was already released. Please add a unreleased section or just add it in the Release PR
|
I’m against adding this check. I think it’s better to document the behavior in the next major release instead. The check negatively impacts performance by verifying the presence of the header with Revert PR: #200 |
| @@ -9,6 +9,7 @@ | |||
| "encodeurl": "^2.0.0", | |||
| "escape-html": "^1.0.3", | |||
| "parseurl": "^1.3.3", | |||
| "depd": "^2.0.0", | |||
There was a problem hiding this comment.
This should go in the HISTORY.md too
|
I really wonder if the user can send those headers. From what I understand of the code, I see that it is not possible, so neither this nor the previous PR was necessary. |
There was a problem hiding this comment.
I would prefer we go with #200. Backing it out is safer than deprecating. We can always follow up with a minor that deprecates it or figure out a way to do it that we would consider non-breaking. We should probably not close this though, so that we could land it after we do the release.
as title