Skip to content

fix: keep footer social icons from shrinking below 16px #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim1999164 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: keep footer social icons from shrinking below 16px #2458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/components/patterns/Footer/Footer.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ import { BodyMd, Button, Col, Container, Grid } from '@/components/primitives';
aria-label="expressjs on GitHub"
target="_blank"
>
<Icon name="github" />
<Icon name="github" size="16" />
</a>
</li>
<li>
Expand All @@ -118,41 +118,41 @@ import { BodyMd, Button, Col, Container, Grid } from '@/components/primitives';
aria-label="expressjs channel on Youtube"
target="_blank"
>
<Icon name="youtube" />
<Icon name="youtube" size="16" />
</a>
</li>
<li>
<a href="https://x.com/UseExpressJS" aria-label="follow expressjs on X account">
<Icon name="x" />
<Icon name="x" size="16" />
</a>
</li>
<li>
<a
href="https://slack-invite.openjsf.org"
aria-label="Join openjs foundation slack group"
>
<Icon name="slack" />
<Icon name="slack" size="16" />
</a>
</li>
<li>
<a
href="https://opencollective.com/express"
aria-label="support expressjs on Open Collective"
>
<Icon name="open-collective" />
<Icon name="open-collective" size="16" />
</a>
</li>
<li>
<a
href="https://bsky.app/profile/expressjs.bsky.social"
aria-label="follow expressjs on bluesky"
>
<Icon name="bsky" />
<Icon name="bsky" size="16" />
</a>
</li>
<li>
<a href="/feed.xml" aria-label="RSS Feed">
<Icon name="rss" />
<Icon name="rss" size="16" />
</a>
</li>
</ul>
Expand Down
20 changes: 19 additions & 1 deletion src/components/patterns/Footer/Footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,32 @@
padding: 0;
margin: 0;
display: flex;
flex-wrap: wrap;
align-items: center;
justify-content: center;
gap: var(--space-6);

li {
display: inline;
display: inline-flex;
flex-shrink: 0;
}

a {
display: inline-flex;
align-items: center;
justify-content: center;
/* Keep a usable hit area even when icons are 16px */
min-width: var(--size-6);
min-height: var(--size-6);
}

svg {
color: var(--color-icon-primary);
flex-shrink: 0;
/* Override reset max-width:100% so flex layout cannot shrink icons */
width: var(--size-4);
height: var(--size-4);
max-width: none;
}

svg path {
Expand Down Expand Up @@ -126,6 +142,8 @@

.kawaii-toggle {
font-size: var(--font-size-sm);
flex-shrink: 0;
white-space: nowrap;
}

.kawaii-toggle[aria-pressed='true'] {
Expand Down
Loading