-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
enhancement: Added Block readme github action #6805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
enhancement: Added Block readme github action #6805
Conversation
Added block readme github action to block spam readme prs. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I don’t think we should have this.
I have added the |
@bjohansebas you should probably have something in place to close these prs, it might seem unneeded but it accumulates to a lot of lost time in the long term, which people exploit. |
This has been a team decision for a long time not to have something like this (#5449 (comment)). Probably the best solution so far would be to use github/ai-moderator (I just remembered that this action exists, which would be the way to move forward with this PR and that way the team could consider accepting it.). I still doubt its effectiveness, but I wouldn’t mind trying it. The PR spam will keep happening until that YouTube tutorial gets taken down, but it seems like that will never happen. example: https://github.com/nodejs/help/blob/main/.github/workflows/spam-detect.yml cc: @expressjs/triagers @expressjs/express-tc |
File name was wrong its Readme, I did README
-Now closes PR
Added issues true, hoping it to close the pr
I also thought to add ai thing here, but the thing is that first thing, ai could make mistakes, second thing, running a github action on a public repo doesn't cost money, while running a github model could cost money source, third why you want a third party (ai model) to read your whole repo, if we have code spam (promotional links) in the whole repo in diff files then it could have make sense, but it seems that the instructor on youtube told her "dear" students to spam on readme. And its just one file, readme could contain typos, which is acceptable in general, and i also added the permissions (only specific person with roles can change the pr), so most folks who got instructed are changing the readme file only so i have added |
Added block readme github action to block spam readme prs. Seeing it from a very long time spam pullrequests have been made and closed.
Thanks.