Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(securite): fix vulnerabilities #6211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abdel-Monaam-Aouini
Copy link

@Abdel-Monaam-Aouini Abdel-Monaam-Aouini commented Dec 6, 2024

image

@IamLizu
Copy link
Member

IamLizu commented Dec 8, 2024

That's some major change with connect-redis. I guess it is used only in the examples,

@bjohansebas
Copy link
Member

There are already individual PRs that do this, I'm writing this from my phone, so I can't search for them easily.

@wesleytodd
Copy link
Member

I thought we had decided to move these examples out of the main repo?I cant find the issue right now, but I think @UlisesGascon opened it? If so, I dont think we should go about updating them here.

@bjohansebas
Copy link
Member

@wesleytodd this is the issue #5309

@wesleytodd
Copy link
Member

Ah thanks for finding that. Yeah I think we need to re-visit that soon here. Either way, I am not sure doing this large update of versions for the dev deps is a good idea either, it opens the door for a bunch of other problems (mainly that we need to vet them all and dont have time for that) and I would rather see us removing things then spending time updating them when the impact is small or non-existent (like in this case)

@UlisesGascon
Copy link
Member

I thought we had decided to move these examples out of the main repo?I cant find the issue right now, but I think @UlisesGascon opened it? If so, I dont think we should go about updating them here.

I didn't have the time to work on that initiative for a long time, also the approach was more valid before we released express v5. So I am +1 to update them as they are now while thinking as a team if we want to keep alive the other initiative or not for 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants