fix: replace yarn with npm due to issues with @isaacs/cliui (#209)

* fix: replace yarn with npm due to issues with `@isaacs/cliui`

* chore: escape `npm run <script>` arguments

* chore: fix linting issues

Author: byCedric

.github/actions/setup-project/action.yml

@@ -9,9 +9,9 @@ inputs:
   with-fixture:
     description: If the setup should install the test/fixture files
     type: boolean
-  
+
   without-cache:
-    description: If the Yarn cache should not be used
+    description: If the Node package cache should not be used
     type: boolean
 
 runs:
@@ -22,10 +22,10 @@ runs:
       uses: actions/setup-node@v3
       with:
         node-version: ${{ inputs.node-version }}
-        cache: yarn
+        cache: npm
         cache-dependency-path: |
-          yarn.lock
-          test/fixture/yarn.lock
+          package-lock.json
+          test/fixture/package-lock.json
 
     - name: 🏗 Setup Node without cache
       if: ${{ inputs.without-cache == 'true' }}
@@ -34,11 +34,11 @@ runs:
         node-version: ${{ inputs.node-version }}
 
     - name: 📦 Install dependencies
-      run: yarn install --frozen-lockfile
+      run: npm ci
       shell: bash
 
     - name: 📦 Install fixture
       if: ${{ inputs.with-fixture == 'true' }}
-      run: yarn install --frozen-lockfile
+      run: npm ci
       working-directory: test/fixture
       shell: bash

.github/workflows/publish.yml

@@ -17,7 +17,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: 🎁 Package extension
-        run: yarn vsce package --yarn
+        run: npx vsce package --npm
         env:
           VSCODE_EXPO_TELEMETRY_KEY: ${{ secrets.TELEMETRY_KEY }}
 
@@ -37,7 +37,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: 🚀 Publish to marketplace
-        run: yarn vsce publish --yarn
+        run: npx vsce publish --npm
         env:
           VSCODE_EXPO_TELEMETRY_KEY: ${{ secrets.TELEMETRY_KEY }}
           VSCE_PAT: ${{ secrets.VSCE_TOKEN }}
@@ -52,7 +52,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: 🎁 Package extension
-        run: yarn vsce package --yarn --out ./vscode-expo.vsix
+        run: npx vsce package --npm --out ./vscode-expo.vsix
         env:
           VSCODE_EXPO_TELEMETRY_KEY: ${{ secrets.TELEMETRY_KEY }}
 

.github/workflows/release.yml

@@ -29,7 +29,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: 📋 Dry-running release
-        run: yarn semantic-release --dry-run
+        run: npx semantic-release --dry-run
         env:
           GITHUB_TOKEN: ${{ github.token }}
 
@@ -46,7 +46,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: 📋 Release code
-        run: yarn semantic-release
+        run: npx semantic-release
         env:
           GITHUB_TOKEN: ${{ secrets.EXPOBOT_GITHUB_TOKEN }}
           GIT_AUTHOR_NAME: Expo CI

.github/workflows/test.yml

@@ -22,7 +22,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: ✅ Lint project
-        run: yarn lint --max-warnings 0
+        run: npm run lint -- --max-warnings 0
 
   scripts:
     runs-on: ubuntu-latest
@@ -34,7 +34,7 @@ jobs:
         uses: ./.github/actions/setup-project
 
       - name: ✅ Test scripts
-        run: yarn test:scripts
+        run: npm run test:scripts
 
   bundled:
     # This extension is bundled before publishing to the stores,
@@ -51,18 +51,18 @@ jobs:
           with-fixture: true
 
       - name: 👷 Build tests
-        run: yarn build
+        run: npm run build
 
       - name: 📦 Bundle extension
-        run: yarn build:production
+        run: npm run build:production
 
       # When bundled, these dependencies aren't available in normal environments.
       # This kind-of fakes such environments, while keeping the required dev packages.
       - name: 🧹 Remove bundled dependencies
         run: rm -rf node_modules/sucrase
 
       - name: 🧪 Test project
-        run: xvfb-run -a yarn test:vscode
+        run: xvfb-run -a npm run test:vscode
         env:
           VSCODE_VERSION: stable
 
@@ -83,7 +83,7 @@ jobs:
           with-fixture: true
 
       - name: 👷 Build project
-        run: yarn build
+        run: npm run build
 
       # This handles the "oldest" vscode version by looking up our "oldest supported version"
       - name: 🕵️ Set vscode version
@@ -99,8 +99,8 @@ jobs:
 
       - name: 🧪 Test project (Linux)
         if: ${{ runner.os == 'Linux' }}
-        run: xvfb-run -a yarn test:vscode
+        run: xvfb-run -a npm run test:vscode
 
       - name: 🧪 Test project (MacOS/Windows)
         if: ${{ runner.os != 'Linux' }}
-        run: yarn test:vscode
+        run: npm run test:vscode

.gitignore

@@ -13,8 +13,6 @@ lerna-debug.log*
 yarn-debug.log*
 yarn-error.log*
 yarn.lock
-package-lock.json
-!/yarn.lock
 
 # test fixtures
 !/test/fixture/yarn.lock

.vscode/tasks.json

@@ -25,7 +25,7 @@
     {
       "label": "install-fixtures",
       "type": "shell",
-      "command": "yarn install --frozen-lockfile --cwd ${workspaceFolder}/test/fixture",
+      "command": "npm install --cwd ${workspaceFolder}/test/fixture",
       "presentation": {
         "reveal": "never"
       }
@@ -53,7 +53,7 @@
     {
       "label": "build-extension",
       "type": "shell",
-      "command": "yarn vsce package",
+      "command": "npx vsce package",
       "group": "build"
     },
     {

.yarnrc

@@ -5,8 +5,8 @@
 1. [Fork](https://help.github.com/articles/fork-a-repo/) this repository to your own GitHub account and then [clone](https://help.github.com/articles/cloning-a-repository/) it to your local device. (`git remote add upstream [email protected]:expo/vscode-expo.git` 😉)
 2. Make sure you have the following packages globally installed on your system:
    - [node](https://nodejs.org/) (active Node LTS or higher is recommended)
-   - [yarn](https://yarnpkg.com/)
-3. Install the Node packages (`yarn install`)
+   - [npm](https://npmjs.com/)
+3. Install the Node packages (`npm install`)
 
 ## 🚗 Start the plugin in development mode
 
@@ -47,9 +47,9 @@ refactor: update loading icon
 
 To help keep CI green, please make sure of the following:
 
-- Run `yarn lint --fix` to fix the formatting of the code. Ensure that `yarn lint` succeeds without errors or warnings.
-- Run `yarn build` to ensure the build runs correctly and without errors or warnings.
-- Run `yarn build:production` to ensure the build runs correctly and without errors or warnings, in production mode.
+- Run `npm run lint -- --fix` to fix the formatting of the code. Ensure that `npm run lint` succeeds without errors or warnings.
+- Run `npm run build` to ensure the build runs correctly and without errors or warnings.
+- Run `npm run build:production` to ensure the build runs correctly and without errors or warnings, in production mode.
 
 ## 🚀 Releasing a new version