Skip to content

[website] login to save #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

[website] login to save #626

merged 2 commits into from
Mar 11, 2025

Conversation

kadikraman
Copy link
Contributor

@kadikraman kadikraman commented Mar 7, 2025

Why

Part of ENG-15173

Guest users should not be able to save Snacks as they would have no way to delete them.

How

Screenshot 2025-03-07 at 16 38 59

Test Plan

Tested locally. The following actions open the "login to save" prompt when not logged in:

  • cmd + S
  • click on save
  • click on download

@kadikraman kadikraman requested a review from byCedric as a code owner March 7, 2025 16:45
Copy link

linear bot commented Mar 7, 2025

@kadikraman kadikraman merged commit aaaa106 into main Mar 11, 2025
5 checks passed
@kadikraman kadikraman deleted the @kadikraman/login-to-save branch March 11, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants