chore!: Build to ES modules #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 2 2
Lines 168 473 +305
Branches 33 40 +7
==========================================
+ Hits 168 473 +305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nicknovitski - is this stale, or might this change still get made? I'm seeing some downstream issues that I can work around, but would be nice if this did go in. |
Member
Author
I still intend to make this change. Sorry for the delay! |
nicknovitski
force-pushed
the
esm
branch
2 times, most recently
from
aa062b3 to
b772de3
Compare
nicknovitski
force-pushed
the
esm
branch
7 times, most recently
from
f717625 to
daedf29
Compare
nicknovitski
requested review from
douglowder
and removed request for
a team
Jest's support for ESM is lacking, so for simplicity this also changes the test suite to use Node's built-in test runner and typescript support, and jest's `expect` package. This change is breaking because any non-ESM consuming packages must now have minumum Node version of 20.19.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I marked this change as breaking because CJS modules running on node versions less than v20.19.0 will need to add the option
--experimental-require-modulein order torequire()the package.CJS modules on v20.19.0 or greater can
require()it by default, and ES modules on node versions 18+ can of courseimportother ES modules without trouble.Jest's support for ESM is lacking, so for simplicity this also changes the test suite to use Node's built-in test runner and typescript support, and jest's
expectpackage.