feat: update the SQLExpression and SQLFragmentHelpers APIs#516
Open
feat: update the SQLExpression and SQLFragmentHelpers APIs#516
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 110 110
Lines 16718 17136 +418
Branches 1519 1518 -1
==========================================
+ Hits 16718 17136 +418
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9536556 to
280809a
Compare
67754b8 to
2b4a3d1
Compare
58fcbf8 to
196c821
Compare
196c821 to
cfec837
Compare
quinlanj
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
The
expressionAPI added in #506 was somewhat poisonous. When doing something likejsonPath('fieldName', 'wat').eq(10), the type information was lost due to typescript not carrying it through chains. So I could do something like:and it would correctly tell me that the field name is invalid (type info carries into single arg).
But the following wouldn't:
How
It's better to just get rid of
expressionthough keep the fluent API on SQLFragmentHelper methods that can carry the type information through the chain.This PR does a few things:
Test Plan
Run new tests.