Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
wschurman
force-pushed
the
@wschurman/04-07-chore_separate_out_build_tsconfig
branch
from
7651148 to
e3c3ac9
Compare
wschurman
force-pushed
the
@wschurman/04-07-feat_add_expo/entity-testing-utils_package
branch
2 times, most recently
from
b64fd88 to
98eef2d
Compare
wschurman
force-pushed
the
@wschurman/04-07-chore_separate_out_build_tsconfig
branch
2 times, most recently
from
eb4f596 to
7ae6c2d
Compare
wschurman
force-pushed
the
@wschurman/04-07-feat_add_expo/entity-testing-utils_package
branch
from
98eef2d to
adf1c53
Compare
wschurman
force-pushed
the
@wschurman/04-07-chore_separate_out_build_tsconfig
branch
from
7ae6c2d to
80f3983
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
===========================================
+ Coverage 99.68% 100.00% +0.31%
===========================================
Files 81 80 -1
Lines 2192 2155 -37
Branches 241 230 -11
===========================================
- Hits 2185 2155 -30
+ Misses 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quinlanj
approved these changes
Apr 8, 2025
sjchmiela
approved these changes
Apr 9, 2025
Member
Author
wschurman
changed the base branch from
@wschurman/04-07-feat_add_expo/entity-testing-utils_package
to
graphite-base/281
wschurman
force-pushed
the
@wschurman/04-07-chore_separate_out_build_tsconfig
branch
from
80f3983 to
81b7e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A follow-up to #280 to no longer include test files in built files. While this shouldn't matter too much (since they weren't in the barrel files) it is still better for sanity.
This allows us to consolidate testfixture pattern and clean up the sync test from #280.
How
Add new tsconfigs, update scripts, update test.
Test Plan
Run tests. Then try
yarn tscandyarn build, inspect the outputs.