Skip to content

[eas-cli] Require rollout update and control update code signing congruency #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wschurman
Copy link
Member

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Size Change: -937 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -937 B (0%)

compressed-size-action

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (6e87e94) to head (a01fa01).

Files with missing lines Patch % Lines
packages/eas-cli/src/project/publish.ts 0.00% 12 Missing ⚠️
packages/eas-cli/src/commands/update/index.ts 60.00% 2 Missing ⚠️
...ackages/eas-cli/src/graphql/queries/BranchQuery.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
+ Coverage   52.64%   52.65%   +0.02%     
==========================================
  Files         588      588              
  Lines       23249    23269      +20     
  Branches     4627     4631       +4     
==========================================
+ Hits        12236    12249      +13     
- Misses      10979    10986       +7     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant