Allow specifying groups option in submit command
#2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -8 B (0%) Total Size: 53.4 MB
|
khamilowicz
force-pushed
the
piotrekszeremeta/eng-14634-add-support-for-groups-option-in-fastlane-pilot-call
branch
3 times, most recently
from
7408a04 to
4892814
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
+ Coverage 52.44% 52.45% +0.01%
==========================================
Files 595 595
Lines 23620 23624 +4
Branches 4697 4699 +2
==========================================
+ Hits 12386 12390 +4
Misses 11199 11199
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/changelog-entry new-feature Add groups option to eas submit command. |
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
approved these changes
Mar 24, 2025
CHANGELOG.md
Outdated
| @@ -1635,6 +1635,7 @@ This is the log of notable changes to EAS CLI and related packages. | |||
| - Add `eas build:run` command which runs iOS simulator builds from the CLI. ([#1447](https://github.com/expo/eas-cli/pull/1447) by [@szdziedzic](https://github.com/szdziedzic)) | |||
| - Add feature gate support. ([#1475](https://github.com/expo/eas-cli/pull/1475) by [@wschurman](https://github.com/wschurman)) | |||
| - Warn about outdated build deployment when configuring EAS Update. ([#1467](https://github.com/expo/eas-cli/pull/1467) by [@fiberjw](https://github.com/fiberjw)) | |||
| - Add groups option to eas submit command. ([#2891](https://github.com/expo/eas-cli/pull/2891) by [@khamilowicz](https://github.com/khamilowicz)) | |||
There was a problem hiding this comment.
Suggested change
| - Add groups option to eas submit command. ([#2891](https://github.com/expo/eas-cli/pull/2891) by [@khamilowicz](https://github.com/khamilowicz)) | |
| - Add `groups` option to `eas submit` command. ([#2891](https://github.com/expo/eas-cli/pull/2891) by [@khamilowicz](https://github.com/khamilowicz)) |
| @@ -89,6 +91,11 @@ export default class Submit extends EasCommand { | |||
| default: false, | |||
| description: 'Enable verbose logging for the submission process', | |||
| }), | |||
| groups: Flags.string({ | |||
| description: 'Testing groups to send the build to (iOS only).', | |||
There was a problem hiding this comment.
Suggested change
| description: 'Testing groups to send the build to (iOS only).', | |
| description: 'Testing groups to send the build to (iOS only)', |
I don't think other descriptions end with a full stop?
szdziedzic
reviewed
Mar 25, 2025
| @@ -89,6 +91,11 @@ export default class Submit extends EasCommand { | |||
| default: false, | |||
| description: 'Enable verbose logging for the submission process', | |||
| }), | |||
| groups: Flags.string({ | |||
There was a problem hiding this comment.
Wouldn't it be better to have it in eas.json? Why/why not?
It probably depends on how people use it 🤔
There was a problem hiding this comment.
I added groups to eas.json.
| @@ -522,6 +522,7 @@ async function prepareAndStartSubmissionAsync({ | |||
| exp: buildCtx.exp, | |||
| vcsClient: buildCtx.vcsClient, | |||
| isVerboseFastlaneEnabled: false, | |||
| groups: [], | |||
There was a problem hiding this comment.
It would be great to allow to set these for eas build --auto-submit as well either through eas.json or as a flag. That's how most people do submissions.
There was a problem hiding this comment.
I added groups to eas.json.
khamilowicz
force-pushed
the
piotrekszeremeta/eng-14634-add-support-for-groups-option-in-fastlane-pilot-call
branch
from
392e8eb to
2573643
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-14634-add-support-for-groups-option-in-fastlane-pilot-call
branch
from
2573643 to
7245efa
Compare
|
✅ Thank you for adding the changelog entry! |
sjchmiela
approved these changes
Apr 7, 2025
| @@ -602,6 +602,11 @@ | |||
| "type": "string", | |||
| "description": "The Bundle identifier that will be used when accessing submit credentials managed by Expo, it does not have any effect if you are using local credentials. In most cases this value will be autodetected, but if you have multiple Xcode schemes and targets, this value might be necessary." | |||
| }, | |||
| "groups": { | |||
| "type": "array", | |||
| "description": "Testing groups to send the build to.", | |||
There was a problem hiding this comment.
I think it would be good to write more about this. What "groups", where can you define them etc.
| @@ -89,6 +91,11 @@ export default class Submit extends EasCommand { | |||
| default: false, | |||
| description: 'Enable verbose logging for the submission process', | |||
| }), | |||
| groups: Flags.string({ | |||
| description: 'Testing groups to send the build to (iOS only)', | |||
There was a problem hiding this comment.
I'd mention what the groups are here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ENG-14634: Add support for
groupsoption infastlane pilotcallUser should be able to pass the
groupsoption tofastlane pilotwhen submitting an iOS build.How
groupsflag in theeas submitcommandsubmission-configTest Plan
eas submit -p ios --groups "Test 1"commandDeployment plan
groupsoption insubmitcommand #2891