Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning instead of error on auth verification failure in REST models #218

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Warning instead of error on auth verification failure in REST models #218

merged 3 commits into from
Jul 13, 2023

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Jul 13, 2023 •
edited
Loading

Description

Warning instead of error on auth verification failure in REST models. This is partially motivated by explosion/spaCy#12820, for which it'd be useful to validate a config and instantiate models without verifying their API access.

Corresponding documentation PR

-

Types of change

Enhancement.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

rmitsch and others added 3 commits July 7, 2023 11:54
@rmitsch
Update PR template. (#207)
58ff497
@rmitsch @svlandeg
Merge pull request #213 from explosion/main
9eef85d 
* Fix regex -> re import. (#205)

* Add 'gpu' marker. (#208)

* Optional authentation verification at init time (#206)

* Add verify_auth param.

* Add _verify_auth() for Cohere and Anthropic.

* Make auth check mandatory again.

* Remove redundant PR.

* Fix OpenLLaMA model names (#209)

* Update PR template. (#207)

* Update OpenLLaMA model names.

* fix model name in documentation (#210)

* Bump version to 0.4.1. (#211)

---------

Co-authored-by: Sofie Van Landeghem <[email protected]>
@rmitsch
Replace errors at auth check with warnings.
3a1a64b
@rmitsch rmitsch added enhancement Improvement of existing feature feat/model Feature: models labels Jul 13, 2023
@rmitsch rmitsch self-assigned this Jul 13, 2023
@rmitsch
Copy link
Collaborator Author

rmitsch commented Jul 13, 2023

Note: this targets main intentionally, as this is blocking explosion/spaCy#12820.

svlandeg
svlandeg approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense. Thanks!

@svlandeg svlandeg merged commit d59c387 into main Jul 13, 2023
@svlandeg svlandeg deleted the chore/auth-warning-instead-of-error branch July 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees

@rmitsch rmitsch

Labels
enhancement Improvement of existing feature feat/model Feature: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @svlandeg