-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support adding pipeline component instances #12710
Open
honnibal
wants to merge
16
commits into
v4
Choose a base branch
from
feat/add-pipe-instance
base: v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6f821ef
Add errors for pipe instance problems
honnibal aa0d747
Support adding pipeline component by instance
honnibal 4332d12
Support adding pipeline component by instance
honnibal b9730a6
Format
honnibal afbdd82
Fix find missing pipes
honnibal 9753484
Fix conflicts
honnibal 77a0859
Format
honnibal dcd8a76
Merge branch 'master' into feat/add-pipe-instance
svlandeg 4cc5bd3
fix
svlandeg 9fcbc8e
add pipe_instances also to load_model_from_init_py
svlandeg 8a79a71
Merge branch 'master' into feat/add-pipe-instance
svlandeg 0fd797e
fix warning numbers
svlandeg 42a373d
Fix error
honnibal 0c8393e
Fix comment
honnibal ef18829
Fix comment
honnibal bc3337d
Fix doc string
honnibal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having this in
load_model_from_init_py
brokenlp = spacy.load("en_core_web_sm")
, which wasn't caught by the test suite :|