Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass MFA login screen when user is already authorized - EXO-65641 #35

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented Jul 31, 2023

When the user is already authorized and entered his verification code, other tabs do not allow bypassing the request of validation code.
The fix will add the missing logic to the Filter to check if the current URL is /mfa-access and that the user is already aithenticated to redirect him to the initial URI

@ahamdi ahamdi requested review from Jihed525 and akhanfir July 31, 2023 15:39
@ahamdi ahamdi self-assigned this Jul 31, 2023
@ahamdi ahamdi enabled auto-merge (squash) July 31, 2023 15:40
Jihed525
Jihed525 previously approved these changes Jul 31, 2023
@ahamdi ahamdi requested a review from Jihed525 July 31, 2023 19:27
@ahamdi ahamdi requested a review from sofyenne July 31, 2023 19:30
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.0% 71.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ahamdi ahamdi merged commit fc538fa into feature/maintenance Jul 31, 2023
3 of 4 checks passed
@ahamdi ahamdi deleted the fix/EXO-65641 branch July 31, 2023 21:57
ahamdi added a commit that referenced this pull request Aug 1, 2023
 (#35)

When the user is already authorized and entered his verification code, other tabs do not allow bypassing the request of validation code.
The fix will add the missing logic to the Filter to check if the current URL is /mfa-access and that the user is already aithenticated to redirect him to the initial URI
ahamdi added a commit that referenced this pull request Aug 1, 2023
 (#35)

When the user is already authorized and entered his verification code, other tabs do not allow bypassing the request of validation code.
The fix will add the missing logic to the Filter to check if the current URL is /mfa-access and that the user is already aithenticated to redirect him to the initial URI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants