Review #1
Open
Review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaer
commented
Sep 5, 2019
| set_order: 16 | ||
| --- | ||
|
|
||
| Reality Tabs are `xr-iframes` which are like `iframes` but will extra spatial attributes like `position`, `scale`, `orientation`. |
There was a problem hiding this comment.
Something like:
Much like
iframes drawn on a 2d page,xr-iframes are 3d sites drawn in a 3d space.
xr-iframeworks with any site or engine that uses WebXR or WebVR.
A high quality video would be good here.
| import('https://web.exokit.org/src/index.js')) | ||
| .then(() => { | ||
| // Create xr-iframe, define src attribute, and append/place it wherever you want as if it was a normal canvas | ||
| const xrIframe = document.createElement('xr-iframe'); |
There was a problem hiding this comment.
Maybe we should call this an xr-scene? It is different from the xr-iframe in usage.
There was a problem hiding this comment.
That makes sense conceptually, since it is possible to render multiple scenes in something like threejs.
There was a problem hiding this comment.
Unlike three though, they would basically be completely separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.