Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelisation and improvement of adapt_grid() #6

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

avigan
Copy link
Contributor

@avigan avigan commented Oct 8, 2024

I propose several improvements for adapt_grid():

  • parallelisation using multiprocessing module and the use of apply_async()
  • creation of the spectro and photo grids without any assumptions on the number of parameters
  • fix for issue Conditions never met adapt_grid() #5 using np.any()
  • use of tqdm instead of the manual computation and formatting of time left

Note that the parallelisation is not super efficient, probably because the underlying functions to adapt the models would require some work to better in a parallel environment, but I still get a factor ~2 improvement on my laptop.

I have checked that the outputs are identical to the current version of ForMoSA in branch activ_dev, except on grid points that were not previously caught as bad points (see issue #5).

@MatthieuR18 MatthieuR18 merged commit 56c6513 into exoAtmospheres:activ_dev Oct 10, 2024
2 checks passed
@avigan avigan deleted the parallel-adapt branch October 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants