Parallelisation and improvement of adapt_grid() #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose several improvements for
adapt_grid()
:multiprocessing
module and the use ofapply_async()
np.any()
tqdm
instead of the manual computation and formatting of time leftNote that the parallelisation is not super efficient, probably because the underlying functions to adapt the models would require some work to better in a parallel environment, but I still get a factor ~2 improvement on my laptop.
I have checked that the outputs are identical to the current version of ForMoSA in branch
activ_dev
, except on grid points that were not previously caught as bad points (see issue #5).