router: remove unreachable code in get_node_id_keypair#1633
Closed
JakeHillion wants to merge 1 commit intomainfrom
Closed
router: remove unreachable code in get_node_id_keypair#1633JakeHillion wants to merge 1 commit intomainfrom
JakeHillion wants to merge 1 commit intomainfrom
Conversation
This code is unreachable, and has already rotted a bit. For example, the generate_ed25519 method is gone, and we use generate elsewhere in the live code. Remove it to avoid confusion. Test plan: - It's dead.
JakeHillion
force-pushed
the
JakeHillion/syyqxzsolzox
branch
from
49dab31 to
75318b4
Compare
Collaborator
|
@JakeHillion Never mind, this is unnecessary after #1619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is unreachable, and has already rotted a bit. For example, the generate_ed25519 method is gone, and we use generate elsewhere in the live code.
Remove it to avoid confusion.
Test plan: