Return error chunk in low memory situations#1626
Draft
rltakashige wants to merge 7 commits intomainfrom
Draft
Conversation
rltakashige
force-pushed
the
leo/handle-low-memory-situations
branch
2 times, most recently
from
1b346d4 to
fef3703
Compare
rltakashige
force-pushed
the
leo/handle-low-memory-situations
branch
from
fef3703 to
20ea13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently allow runners (and their instance) to OOM. Let's try to prevent this as much as possible.
Changes
Test Plan
Manual Testing
Seems to work on Mac Minis.
Automated Testing
Wrote a test script to test this, but it's very flaky so won't be in the final PR.