Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .env launch time loading #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zpalmtree
Copy link

@zpalmtree zpalmtree commented Oct 1, 2021

The initial go live date of the candy machine is loaded from the .env file. However, javascript's Date constructor expects to be given a value in milliseconds, not seconds, as is the convention for unix timestamps.
This bug may not have been observed, as the true go live date is loaded from the candy machine soon after page load.

Type of change

  • Bug fix

How Has This Been Tested?

  • Set REACT_APP_CANDY_START_DATE to a unix timestamp in the future, such as 1640998800 (2022)
  • Set candy machine backing it to have the same start date
  • Observe on load the 'Mint' button will be available for a few seconds before state is fetched from the server.
  • Presumably this can be extended for testing by disabling internet connection
  • After patch applied, Mint button should correctly show countdown right after page load

@thaking86
Copy link

thaking86 commented Oct 1, 2021 via email

kornelHub pushed a commit to kornelHub/candy-machine-mint that referenced this pull request Jun 27, 2022
bug fix - preview image generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants