Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design layout #90

Closed
wants to merge 2 commits into from
Closed

Design layout #90

wants to merge 2 commits into from

Conversation

ohaddahan
Copy link

Description

Design layout, improved configurability (still need some extra loving).

Type of change

  • New feature
  • Refactor

How Has This Been Tested?

  • Manual test (need more)

ohaddahan and others added 2 commits September 30, 2021 15:41
* show > 24 hours correctly

* show inventory

* s/Address/Wallet/

* upgrade anchor

Co-authored-by: Levi Cook <[email protected]>
* temp

* Temp

* Fixing styling

* More styling

* footers

* Stage 1 ready
@levicook
Copy link
Contributor

This looks very extensive and makes me worry that it's getting too far from the goals of the project. This is meant to be a fork and customize starter app & it's supposed to start off looking a bit rough.

If you think this enables that please attach screeshots or a loom video showing how that's accomplished.

@G-R-G
Copy link

G-R-G commented Sep 30, 2021

Hi, after I followed all of the steps, I got this error, when I tried to run the command "yarn start".
./src/pages/home.scss (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/postcss-loader/src??postcss!./node_modules/resolve-url-loader??ref--5-oneOf-6-3!./node_modules/sass-loader/dist/cjs.js??ref--5-oneOf-6-4!./src/pages/home.scss)
Cannot find module 'sass'

@ohaddahan
Copy link
Author

ohaddahan commented Sep 30, 2021

This looks very extensive and makes me worry that it's getting too far from the goals of the project. This is meant to be a fork and customize starter app & it's supposed to start off looking a bit rough.

If you think this enables that please attach screeshots or a loom video showing how that's accomplished.

Loom video : https://www.loom.com/share/ae7ce23b708a4009843bafa60045317d

I agree it might be a big change, it's supposed to help kick start even faster.
Maybe it should just be a fork, and #39 also.
With the main README pointing to them as an option.

The only thing we need from the main repo is to to keep similar structure to https://github.com/Realtyka/real-commons/pull/79 , that way there will be no crazy syncs.

What do you think, better go that route?

@ohaddahan
Copy link
Author

Cannot find module 'sass'

I think this should work laravel-mix/laravel-mix#2103

@G-R-G
Copy link

G-R-G commented Oct 2, 2021

Hello guys, can you show me the way to change the connect and mint button, I tried to change the Navbar.scss but it just added a layer on top of the existing background of the button. I tried to style it in the ConnectionMintButton.tsx but It didn't work out.

@ohaddahan
Copy link
Author

Hello guys, can you show me the way to change the connect and mint button, I tried to change the Navbar.scss but it just added a layer on top of the existing background of the button. I tried to style it in the ConnectionMintButton.tsx but It didn't work out.

can you post what you tried?

@ohaddahan
Copy link
Author

Closing, will keep it as a separate fork as @levicook mentioned, it might be too big of a change.

@ohaddahan ohaddahan closed this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants