Annalyn's Infiltration - Task 4 - Instructions don't match tests

[sarad1p1ty]

As per #758:

• Add a logic table (inputs and expected result) to exercises/concept/annalyns-infiltration/.meta/design.md to ensure proper wording of instructions for the future
  - [ ] Find wording that matches the logic of the tests
• Change Instructions wording to explicitly state that if the dog is present it does not matter if the prisoner is asleep or awake.
• Order tests to follow the sequence of instruction conditions (e.g. the first statement is "If Annalyn has her pet dog with her" -> first all tests "with dog" then all tests "without dog")
• Ask in forum about wording and logic issues of the new version
• Rename exercise title to Annalyn's Infiltration (apostrophe added)

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

I think you can't look into the CI details, there are some formatting issues reported:

> phpcs

FILE: ...p/php/exercises/concept/annalyns-infiltration/AnnalynsInfiltrationTest.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------
 223 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 240 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 257 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 274 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 308 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 325 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 410 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 461 | ERROR | [x] Whitespace found at end of line
     |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)

[mk-mxp]

Thanks for investing your time into this! Looking forward to merging soon.

[mk-mxp]

Thanks for your contribution! There where no suggestions for wording changes in the forum, too.

[sarad1p1ty]

Thank you! :D
Is there anything else I can do?

[mk-mxp]

@sarad1p1ty Did you look through the GitHub issues list? There is lots of things to do, with and without in-depth PHP / PHPUnit / Exercism knowledge. Synchronising exercises from the common problem specifications repository, adding missing exercises from that repository, adding concept exercises (adapted from other Exercism languages with similar concepts) aso. Pick something and I'll make an issue / forum thread with detailed instructions.