Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync robot-simulator #784

Merged
merged 13 commits into from
Aug 3, 2024
Merged

Sync robot-simulator #784

merged 13 commits into from
Aug 3, 2024

Commits on Jul 27, 2024

  1. Sync instructions with configlet

    @mk-mxp
    mk-mxp committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ebf7ebd View commit details
    Browse the repository at this point in the history

  2. Drop useless strict types comments

    @mk-mxp
    mk-mxp committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    19954ce View commit details
    Browse the repository at this point in the history

  3. Sync tests to problem specs 

    Also spreads tests out to indepent test methods, uses only the defined
interface from problem spec and still is compatible with existing
solutions.
    @mk-mxp
    mk-mxp committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    cd7f4e1 View commit details
    Browse the repository at this point in the history

  4. Reduce stub to now tested interface

    @mk-mxp
    mk-mxp committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9e983cd View commit details
    Browse the repository at this point in the history

  5. Higher difficulty of the exercise

    @mk-mxp
    mk-mxp committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    3bfc691 View commit details
    Browse the repository at this point in the history

  6. Test names like problem spec 

    README translates to instructions nowadays
    @mk-mxp
    mk-mxp committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    a358031 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Do not use student provided constants but strings 

    This takes the exercise closer to problem specifications
    @mk-mxp
    mk-mxp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c749974 View commit details
    Browse the repository at this point in the history

  2. Rename class Robot -> RobotSimulator 

    This breaks all existing solutions.
    @mk-mxp
    mk-mxp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3ab6ab1 View commit details
    Browse the repository at this point in the history

  3. Use getter methods instead of properties 

    This provides proper encapsulation. Also breaks all existing solutions.
    @mk-mxp
    mk-mxp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    73f64fd View commit details
    Browse the repository at this point in the history

  4. Streamline example code 

    - Remove dead code
- Adhere to interface of student stub
- Type annotations, typos, code order
    @mk-mxp
    mk-mxp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c57d888 View commit details
    Browse the repository at this point in the history

  5. Add a design write-up for the exercise

    @mk-mxp
    mk-mxp committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c5d81ba View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Further optimisation suggested in review

    @mk-mxp
    mk-mxp committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    3dfd5ea View commit details
    Browse the repository at this point in the history

  2. Order movements according to instructions 

    OK, that's pedantic. But computers are pedantic.
    @mk-mxp
    mk-mxp committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    fcd6ec1 View commit details
    Browse the repository at this point in the history