Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync rna-transcription #737

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Conversation

fejan-malek
Copy link
Contributor

Changes which have been made till now.

  • change: uuid and testdox added in test file for rna-transcription
  • MD file formatted for rna-transcription
  • remove: strict types from rna-transcription

Needs to be done for

Decide on adding / adjusting / ordering test cases to match current problem specs
metadata: unsynced: rna-transcription

#730

Copy link

github-actions bot commented Jun 9, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the UUIDs and descriptions from problem specification canonical-data.json.

Each test case has a "uuid" field to use with the uuid comment and a "description" field to use with @testdox. Also make sure, that "input" and "expected" are used in the test method, not other values.

In the end, please sort the tests according to the order in canonical-data.json, as this is the recommended test order.

Thanks for jumping in and helping!

@mk-mxp mk-mxp changed the title Change rna-transcription Sync rna-transcription Jun 9, 2024
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jun 9, 2024
@mk-mxp
Copy link
Contributor

mk-mxp commented Jun 9, 2024

@fejan92 Are you still working on this? Click "Re-request review" next to my name in "Reviewers" when you are done.

Needs to be done for

Decide on adding / adjusting / ordering test cases to match current problem specs

I took a look into the existing solutions. It is OK to add the missing test as specified in canonical-data.json https://github.com/exercism/problem-specifications/blob/main/exercises/rna-transcription/canonical-data.json The expected value you used is not OK.

@fejan-malek
Copy link
Contributor Author

canonical-data.json

I have update the test cases here. For canonical-data.json I need to clone that project and update the test cases there also.

@fejan-malek fejan-malek requested a review from mk-mxp June 9, 2024 10:57
@fejan-malek fejan-malek requested a review from mk-mxp June 10, 2024 08:44
@fejan-malek
Copy link
Contributor Author

Only input and expected remain to add in textdoc documentation

Please tell me if the below is proper documentation after that I will update in the test file

    /**
     * @testdox RNA complement
     * @input UGCACCAGAAUU
     * @expected UCGGCCGUGAAAU
     * uuid 79ed2757-f018-4f47-a1d7-34a559392dbf
     */
    public function testTranscribesAllOccurrencesOne(): void
    {
       ...body
    }

@mk-mxp
Copy link
Contributor

mk-mxp commented Jun 10, 2024

Only input and expected remain to add in textdoc documentation

Please tell me if the below is proper documentation after that I will update in the test file

    /**
     * @testdox RNA complement
     * @input UGCACCAGAAUU
     * @expected UCGGCCGUGAAAU
     * uuid 79ed2757-f018-4f47-a1d7-34a559392dbf
     */
    public function testTranscribesAllOccurrencesOne(): void
    {
       ...body
    }

No, thanks. Don't do that.

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping with that! There was much to learn about the Exercism internals for you. Nice work!

@mk-mxp mk-mxp merged commit bc04684 into exercism:main Jun 10, 2024
12 checks passed
@fejan-malek fejan-malek deleted the change-rna-transcription branch June 10, 2024 09:04
@fejan-malek
Copy link
Contributor Author

Thank you.

Hope I am not messing up things. Yes as a beginner I am making mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants