-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync rna-transcription #737
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the UUIDs and descriptions from problem specification canonical-data.json
.
Each test case has a "uuid"
field to use with the uuid
comment and a "description"
field to use with @testdox
. Also make sure, that "input"
and "expected"
are used in the test method, not other values.
In the end, please sort the tests according to the order in canonical-data.json
, as this is the recommended test order.
Thanks for jumping in and helping!
@fejan92 Are you still working on this? Click "Re-request review" next to my name in "Reviewers" when you are done.
I took a look into the existing solutions. It is OK to add the missing test as specified in |
I have update the test cases here. For |
…blem specification
Only Please tell me if the below is proper documentation after that I will update in the test file /**
* @testdox RNA complement
* @input UGCACCAGAAUU
* @expected UCGGCCGUGAAAU
* uuid 79ed2757-f018-4f47-a1d7-34a559392dbf
*/
public function testTranscribesAllOccurrencesOne(): void
{
...body
} |
No, thanks. Don't do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for helping with that! There was much to learn about the Exercism internals for you. Nice work!
Thank you. Hope I am not messing up things. Yes as a beginner I am making mistakes. |
Changes which have been made till now.
Needs to be done for
Decide on adding / adjusting / ordering test cases to match current problem specs
metadata: unsynced: rna-transcription
#730