-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync space age #724
Sync space age #724
Conversation
There were no changes, that might cause valid implementations to fail.
This also does not invalidate any existing solution
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Thank you!
About the "wrong planet test", I'm not sure we should skip it though. But as this exercise is rather popular I think this will affect a lot of people.
The whole exercise is centered around floating point numbers and very easy. Having exceptions seems odd to me, as we specify all planets as methods explicitly. There are more advanced exercises, where adding such a test makes more sense. I think that test is for approaches using "planet name to data structure / method / function mapping in student land", where one should actually have such a test. With the complete interface and all methods pre-declared - why should anyone try to use |
This will be the
#48in24
exercise on 2024-06-04. Important files changed, but re-running tests on submitted student code not required.seconds
, as that should not be tested forCloses #713