Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync space age #724

Merged
merged 4 commits into from
May 31, 2024
Merged

Sync space age #724

merged 4 commits into from
May 31, 2024

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented May 27, 2024

This will be the #48in24 exercise on 2024-06-04. Important files changed, but re-running tests on submitted student code not required.

  • Documentation sync'ed and checked for mismatches to track tests
  • Tests sync'ed with the problem specs
  • I did not add the test for a wrong planet, as that makes all existing solutions invalid
  • Removed the test for internal storage of seconds, as that should not be tested for

Closes #713

There were no changes, that might cause valid implementations to fail.
This also does not invalidate any existing solution
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels May 27, 2024
@mk-mxp mk-mxp requested a review from homersimpsons May 27, 2024 09:36
@mk-mxp mk-mxp self-assigned this May 27, 2024
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Thank you!

About the "wrong planet test", I'm not sure we should skip it though. But as this exercise is rather popular I think this will affect a lot of people.

@mk-mxp
Copy link
Contributor Author

mk-mxp commented May 31, 2024

About the "wrong planet test"

The whole exercise is centered around floating point numbers and very easy. Having exceptions seems odd to me, as we specify all planets as methods explicitly. There are more advanced exercises, where adding such a test makes more sense.

I think that test is for approaches using "planet name to data structure / method / function mapping in student land", where one should actually have such a test. With the complete interface and all methods pre-declared - why should anyone try to use __call() to implement everything dynamically? That would be the only way I see to make use of an exception for a wrong planet.

@mk-mxp mk-mxp merged commit 0357b59 into exercism:main May 31, 2024
13 checks passed
@mk-mxp mk-mxp deleted the sync-space-age branch May 31, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#48in24: space-age 2024-06-04
2 participants