Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arrays concept #723

Merged
merged 8 commits into from
May 25, 2024
Merged

Fix arrays concept #723

merged 8 commits into from
May 25, 2024

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented May 24, 2024

The issue was reported in #661, I added some minor improvements in wording and formatting.

@mk-mxp mk-mxp added x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/concept Work on Concepts x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels May 24, 2024
@mk-mxp mk-mxp requested a review from homersimpsons May 24, 2024 12:51
@mk-mxp mk-mxp self-assigned this May 24, 2024
homersimpsons
homersimpsons reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. I added some comments to try to get an even better documentation.

concepts/arrays/about.md Outdated Show resolved Hide resolved
concepts/arrays/about.md Outdated Show resolved Hide resolved
concepts/arrays/introduction.md Outdated Show resolved Hide resolved
exercises/concept/language-list/.docs/introduction.md Outdated Show resolved Hide resolved
@mk-mxp @homersimpsons
Use only valid prime numbers
6109a9f 
Co-authored-by: homersimpsons <[email protected]>
@mk-mxp mk-mxp requested a review from homersimpsons May 25, 2024 12:29
@mk-mxp mk-mxp merged commit 86775f6 into exercism:main May 25, 2024
12 checks passed
@mk-mxp mk-mxp deleted the fix-arrays-concept branch May 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homersimpsons homersimpsons homersimpsons approved these changes

Assignees

@mk-mxp mk-mxp

Labels
x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/concept Work on Concepts x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mk-mxp @homersimpsons