Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the protein-translation exercise. #536

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

MichaelBunker
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 5, 2023
@neenjaw neenjaw reopened this Aug 6, 2023
@neenjaw neenjaw self-requested a review August 6, 2023 01:47
@neenjaw neenjaw added the x:module/practice-exercise Work on Practice Exercises label Aug 6, 2023
Copy link
Collaborator

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once you look at the feedback for #534 I think a few of the same comments can be applied here, but I don't want to nag.

Happy to merge this optimistically, let me know what you'd like to do

@MichaelBunker
Copy link
Contributor Author

@neenjaw This is ready for your review. Removed topics, changed the exception to \BadMethodCall and removed the use of static per your feedback.

@neenjaw neenjaw added x:size/large Large amount of work x:rep/large Large amount of reputation labels Aug 19, 2023
@neenjaw neenjaw merged commit e78d08e into exercism:main Aug 19, 2023
20 checks passed
@MichaelBunker MichaelBunker deleted the protein-translation branch August 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants