Change: Defined const for diagram repeating value in testcases

exercism · Jun 28, 2024 · 1f9e723 · 1f9e723
1 parent 047d93f
commit 1f9e723
Showing 1 changed file with 14 additions and 24 deletions.
diff --git a/exercises/practice/kindergarten-garden/KindergartenGardenTest.php b/exercises/practice/kindergarten-garden/KindergartenGardenTest.php
@@ -4,6 +4,8 @@
 
 class KindergartenGardenTest extends PHPUnit\Framework\TestCase
 {
+    const DIAGRAM = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
+
     public static function setUpBeforeClass(): void
     {
         require_once 'KindergartenGarden.php';
@@ -65,8 +67,7 @@ public function testThirdStudentsGarden(): void
      */
     public function testFullGardenForAlice(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(['violets', 'radishes', 'violets', 'radishes'], $garden->plants('Alice'));
     }
 
@@ -76,8 +77,7 @@ public function testFullGardenForAlice(): void
      */
     public function testFullGardenForBob(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(['clover', 'grass', 'clover', 'clover'], $garden->plants('Bob'));
     }
 
@@ -87,8 +87,7 @@ public function testFullGardenForBob(): void
      */
     public function testFullGardenForCharlie(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(['violets', 'violets', 'clover', 'grass'], $garden->plants('Charlie'));
     }
 
@@ -98,8 +97,7 @@ public function testFullGardenForCharlie(): void
      */
     public function testFullGardenForDavid(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["radishes", "violets", "clover", "radishes"], $garden->plants('David'));
     }
 
@@ -109,8 +107,7 @@ public function testFullGardenForDavid(): void
      */
     public function testFullGardenForEve(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["clover", "grass", "radishes", "grass"], $garden->plants('Eve'));
     }
 
@@ -120,8 +117,7 @@ public function testFullGardenForEve(): void
      */
     public function testFullGardenForFred(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["grass", "clover", "violets", "clover"], $garden->plants('Fred'));
     }
 
@@ -131,8 +127,7 @@ public function testFullGardenForFred(): void
      */
     public function testFullGardenForGinny(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["clover", "grass", "grass", "clover"], $garden->plants('Ginny'));
     }
 
@@ -142,8 +137,7 @@ public function testFullGardenForGinny(): void
      */
     public function testFullGardenForHarriet(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["violets", "radishes", "radishes", "violets"], $garden->plants('Harriet'));
     }
 
@@ -153,8 +147,7 @@ public function testFullGardenForHarriet(): void
      */
     public function testFullGardenForIleana(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["grass", "clover", "violets", "clover"], $garden->plants('Ileana'));
     }
 
@@ -164,8 +157,7 @@ public function testFullGardenForIleana(): void
      */
     public function testFullGardenForJoseph(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["violets", "clover", "violets", "grass"], $garden->plants('Joseph'));
     }
 
@@ -175,8 +167,7 @@ public function testFullGardenForJoseph(): void
      */
     public function testFullGardenForKincaid(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["grass", "clover", "clover", "grass"], $garden->plants('Kincaid'));
     }
 
@@ -186,8 +177,7 @@ public function testFullGardenForKincaid(): void
      */
     public function testFullGardenForLarry(): void
     {
-        $diagram = "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV";
-        $garden = new KindergartenGarden($diagram);
+        $garden = new KindergartenGarden(self::DIAGRAM);
         $this->assertEquals(["grass", "violets", "clover", "violets"], $garden->plants('Larry'));
     }
 }