Skip to content

Conversation

oxe-i
Copy link

@oxe-i oxe-i commented Jul 28, 2025

The code in ./src/prepare.ts wasn't deleting/commenting out jest global imports over multiple lines. Added a fix.

@oxe-i
Copy link
Author

oxe-i commented Jul 28, 2025

@oxe-i
Copy link
Author

oxe-i commented Jul 28, 2025

Reverted back to indexOf as it doesn't seem to matter for the test and as the global import was already commented out before.

But I believe that right now the text is injected after the first from which can be the one from the global imports (now commented out). So not necessarily after the main import.

@SleeplessByte SleeplessByte self-assigned this Jul 28, 2025
@SleeplessByte SleeplessByte self-requested a review July 28, 2025 13:36
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
@oxe-i
Copy link
Author

oxe-i commented Jul 28, 2025

@SleeplessByte Committed the change you suggested. Do I need to do anything more?

@SleeplessByte
Copy link
Member

@oxe-i thanks! Nope, just going to do another fix and then I'll merge both together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants