Tweak pangram tests per canonical-data #153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegillet
reviewed
Jan 23, 2023
| } | ||
|
|
||
| pub fn a_m_and_upper_a_m_are_26_different_characters_but_not_a_pangram_test() { | ||
| pub fn a_m_and_a_m_are_26_different_characters_but_not_a_pangram_test() { |
There was a problem hiding this comment.
I think the previous title was better, lost in generation I suppose
There was a problem hiding this comment.
Hm, yeah you're right, they get lost in the generation. I'm going to see if I can improve the test title upstream and regenerate.
lpil
reviewed
Jan 23, 2023
|
I took another look at this and the include=false should actually be present, because it's been reimplemented with a different description and different (but equivalent) data. I'm going to put this one on hold while I look at the upstream fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an include=false from the tests.toml, as the
exclusion seems to have been unintentional (the new test
passes with no changes to the example solution).
It also switches to use the should.be_false / should.be_true style
that other tests use, rather than assert False / assert True.